Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#275) Excel ์ถ”๊ฐ€ #276

Closed
wants to merge 14 commits into from
Closed

๐Ÿ”€ :: (#275) Excel ์ถ”๊ฐ€ #276

wants to merge 14 commits into from

Conversation

osangu
Copy link
Member

@osangu osangu commented Oct 19, 2022

close #275

ํ˜„์žฌ ํ•™์ƒ๋“ค์˜ ์ •๋ณด( ํ•™๋ฒˆ, ์ด๋ฆ„, ๋Œ€๊ธฐ ๋ฌธ์„œ ์—ฌ๋ถ€, ๊ณต๊ฐœ ๋ฌธ์„œ ์—ฌ๋ถ€, ํ”ผ๋“œ๋ฐฑ ์ƒํƒœ)๋ฅผ ํฌํ•จํ•œ ์—‘์…€์„ ๋‹ค์šด๋กœ๋“œ ๋ฐ›๋Š” API์ž…๋‹ˆ๋‹ค.

@osangu osangu added the ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค. label Oct 19, 2022
@osangu osangu self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #276 (213a499) into main (6adf826) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #276      +/-   ##
============================================
- Coverage     35.51%   34.62%   -0.90%     
  Complexity      256      256              
============================================
  Files           229      233       +4     
  Lines          2044     2097      +53     
  Branches         34       38       +4     
============================================
  Hits            726      726              
- Misses         1307     1360      +53     
  Partials         11       11
Impacted Files Coverage ฮ”
.../domain/teacher/excel/StudentXSSFExcelCreator.java 0.00% <0.00%> (รธ)
...domain/teacher/excel/exception/ExcelErrorCode.java 0.00% <0.00%> (รธ)
.../teacher/excel/exception/ExcelOutPutException.java 0.00% <0.00%> (รธ)
...domain/teacher/presentation/TeacherWebAdapter.java 0.00% <0.00%> (รธ)
...dsm/yapaghetti/global/security/SecurityConfig.java 0.00% <0.00%> (รธ)
...main/document/presentation/DocumentWebAdapter.java 0.00% <0.00%> (รธ)
.../document/usecase/ReturnPublicDocumentUseCase.java 0.00% <0.00%> (รธ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@osangu osangu requested a review from eogus2513 October 19, 2022 02:17
@osangu osangu requested a review from eogus2513 October 19, 2022 02:21
@osangu osangu requested a review from eogus2513 October 19, 2022 02:27
@osangu osangu marked this pull request as draft October 19, 2022 12:31
@osangu osangu marked this pull request as ready for review October 19, 2022 12:55
@osangu osangu requested a review from glay415 October 19, 2022 12:55
osangu
osangu commented Oct 22, 2022
View reviewed changes
Copy link
Member Author

@osangu osangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ „๋ฐ˜์ ์œผ๋กœ ๋ณ€์ˆ˜๋ช… ๊ด€๋ฆฌ๊ฐ€ ํ•„์š”ํ•  ๊ฒƒ ๊ฐ™์•„์š”.

.../src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/exception/ExcelOException.java Outdated Show resolved Hide resolved
.../src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/exception/ExcelOException.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated
Comment on lines 44 to 51
for (StudentElementByGradeClassNum element : excelElement) {
Row row = sheet.createRow(rowNum++);
row.createCell(0).setCellValue(element.getGcn());
row.createCell(1).setCellValue(element.getName());
row.createCell(2).setCellValue(element.isFeedbackStatus() ? "O" : null);
row.createCell(3).setCellValue(element.isSubmitted() ? "O" : null);
row.createCell(4).setCellValue(element.isPublicStatus() ? "O" : null);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5;

excelElement.stream()
  .forEach(element -> {
    ...
})

osangu
osangu commented Oct 22, 2022
View reviewed changes
Copy link
Member Author

@osangu osangu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ‘๐Ÿ‘๐Ÿ‘

...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated
}

try {
String time = LocalDateTime.now()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3; ํƒ€์ž„์กด ๊ด€๋ฆฌ๋Š” ๋”ฐ๋กœ ํ•„์š” ์—†์„๊นŒ์š”?

...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...e/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/presentation/TeacherWebAdapter.java
Comment on lines +169 to +172
@GetMapping("/excel")
public void getExcel(HttpServletResponse response) {
createExcelInterface.execute(response);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5; ๋” ์ข‹์€ ๋‹ค๋ฅธ ๋ฐฉ๋ฒ•์ด ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”...

Copy link
Member

@LeagueLugas LeagueLugas Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OutputStream์„ ๊ทธ๋Œ€๋กœ return ํ•˜๋ฉด ์–ด๋–ป๊ฒŒ ๋˜๋ ค๋‚˜?
์˜ˆ์ „์— ๋น„์Šทํ•˜๊ฒŒ ํ–ˆ๋˜๊ฑฐ ๊ฐ™์€๋””, ํ•จ ์‚ฝ์งˆ ํ•ด๋ด๋ฐ”
https://github.com/EntryDSM/Husky/blob/master/src/main/java/kr/hs/entrydsm/husky/domain/pdf/controller/PDFExportController.java

@leeseojune53
Copy link
Member

์ƒ์šฐ๊ณ„์ •์œผ๋กœ ๋Œ“๊ธ€์„ ๋‹จ๊ฑฐ์•ผ ์•„๋‹ˆ๋ฉด ์ƒ์šฐ๊ฐ€ ์ด์ค‘์ธ๊ฒฉ์ด๋œ๊ฑฐ์•ผ

LeagueLugas
LeagueLugas reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@LeagueLugas LeagueLugas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž˜ ์ง€๋‚ด๋ƒ

...e/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/presentation/TeacherWebAdapter.java
Comment on lines +169 to +172
@GetMapping("/excel")
public void getExcel(HttpServletResponse response) {
createExcelInterface.execute(response);
}
Copy link
Member

@LeagueLugas LeagueLugas Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OutputStream์„ ๊ทธ๋Œ€๋กœ return ํ•˜๋ฉด ์–ด๋–ป๊ฒŒ ๋˜๋ ค๋‚˜?
์˜ˆ์ „์— ๋น„์Šทํ•˜๊ฒŒ ํ–ˆ๋˜๊ฑฐ ๊ฐ™์€๋””, ํ•จ ์‚ฝ์งˆ ํ•ด๋ด๋ฐ”
https://github.com/EntryDSM/Husky/blob/master/src/main/java/kr/hs/entrydsm/husky/domain/pdf/controller/PDFExportController.java

...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
...astructure/src/main/java/kr/hs/entrydsm/yapaghetti/domain/teacher/excel/CreateExcelImpl.java Outdated Show resolved Hide resolved
@osangu osangu requested a review from eogus2513 October 25, 2022 07:40
@osangu
Copy link
Member Author

osangu commented Oct 25, 2022 •
edited
Loading

queryDSL ํ•จ์ˆ˜๋ช… ์ •์ •์€, ๋‹ค๋ฅธ ๋ถ€๋ถ„์—์„œ๋„ ์‚ฌ์šฉํ•จ์œผ๋กœ, #277 ํ†ตํ•ด ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

P. S
์ €์•ผ ์ž˜ ์ง€๋‚ด์ฃ  ใ…Žใ…Ž ๋ฆฌ๋ทฐ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!!
์ต๋ช…์œผ๋กœ ๋ฆฌ๋ทฐ ํ•ด์ฃผ์‹  ๊ฑด๋Œ€ ์˜ฌ๋นผ๋ฏธ์™€ ๊นŒ์น˜์‚ฐ ๋„๋งˆ๋ฑ€๋„ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ๐Ÿ‘

@osangu osangu closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeagueLugas LeagueLugas LeagueLugas left review comments

@leeseojune53 leeseojune53 Awaiting requested review from leeseojune53 leeseojune53 is a code owner

@syxxn syxxn Awaiting requested review from syxxn syxxn is a code owner

@softpeanut softpeanut Awaiting requested review from softpeanut softpeanut is a code owner

@glay415 glay415 Awaiting requested review from glay415 glay415 is a code owner

@eogus2513 eogus2513 Awaiting requested review from eogus2513 eogus2513 is a code owner

Assignees

@osangu osangu

Labels
๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

์—‘์…€ ์ƒ์„ฑ API
6 participants
@osangu @leeseojune53 @LeagueLugas @eogus2513 @softpeanut @glay415